1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
#include <stdio.h>
#include <stdlib.h>
#include <stdbool.h>
#include <assert.h>

// BROKEN -- will not work as is
// - preprocessor directive must be all one line (except for \ continuations)
// - there will also be a nasty semicolon issue.
#define print_noun(noun, count)            \
    do {                                   \
        if(count != 1) {                   \
            printf("%d %ss", count, noun); \
        }                                  \
        else {                             \
            printf("%d %s", count, noun);  \
        }                                  \
    } while(false)

// RULE:  Replacement side of a #define function-like macro should work even if
//        you put a semicolon at the end of it.  do { … } while(false) is the only way
//        to make that work for multi-like function-like macros.

int main(int argc, char* argv[]) {
    int n = 7;

    // WE ARE BREAKING A CODE QUALITY RULE HERE. 
    // Always use {…} with if/for/while/switch/functions.

    if(n == 7)
        print_noun("apple", 1);   // <-- This semicolon will make the do/while correct.
    else
        print_noun("apple", 10);

    return EXIT_SUCCESS;
}
/* vim: set tabstop=4 shiftwidth=4 fileencoding=utf-8 noexpandtab: */

© Copyright 2022 Alexander J. Quinn         This content is protected and may not be shared, uploaded, or distributed.